Skip re-writing the same values to components, to satisfy bevy's change detection. #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adds some verbosity, happy to make any style / naming changes or whatever you suggest. |
Jondolf
requested changes
Oct 10, 2023
Co-authored-by: Joona Aalto <[email protected]>
Co-authored-by: Joona Aalto <[email protected]>
Co-authored-by: Joona Aalto <[email protected]>
Co-authored-by: Joona Aalto <[email protected]>
Jondolf
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, a dynamic body (that isn't sleeping) with zero Linear and Angular velocity will still get its Position, Rotation, LinearVelocity, and AngularVelocity updated every tick (re-set to the same values).
This shows up if you use a
Query<Entity, Changed<Position>>query filter, for example.These commits guard against updating the components unless the value will actually change.
I noticed this while debugging some netcode that serializes and sends changed component values.